Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broker: add year to log timestamps #6574

Merged
merged 1 commit into from
Jan 23, 2025
Merged

Conversation

grondo
Copy link
Contributor

@grondo grondo commented Jan 23, 2025

Problem: Flux broker log timestamps do not contain the year. This makes it difficult for users to determine when an error or other log message occurred in historical job output files.

Add the year to log timestamps emitted by the broker.

Fixes #6569

Problem: Flux broker log timestamps do not contain the year. This
makes it difficult for users to determine when an error or other
log message occurred in historical job output files.

Add the year to log timestamps emitted by the broker.
Copy link
Member

@chu11 chu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you did forget the "Fixes ..." in the commit message though.

@grondo
Copy link
Contributor Author

grondo commented Jan 23, 2025

Thanks! (Fixes is in the PR message) Will set MWP.

@mergify mergify bot merged commit ef85a55 into flux-framework:master Jan 23, 2025
35 checks passed
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.44%. Comparing base (2088011) to head (014ace5).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6574      +/-   ##
==========================================
+ Coverage   79.43%   79.44%   +0.01%     
==========================================
  Files         531      531              
  Lines       88309    88311       +2     
==========================================
+ Hits        70145    70161      +16     
+ Misses      18164    18150      -14     
Files with missing lines Coverage Δ
src/broker/log.c 74.92% <100.00%> (+0.14%) ⬆️

... and 10 files with indirect coverage changes

@grondo grondo deleted the issue#6569 branch January 23, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

include year in broker log timestamps
2 participants